Add resources.consent conditional dependency back

[anoadragon453]

This conditional dependency was removed as part of #8037. Turns out that the codebase checks for this removed key explicitly:

synapse/synapse/config/server.py

Line 1150 in 5c43c43

check_requirements("resources.consent")

This was breaking Element-Web's CI and possibly other things we're unaware of.

Rather than remove that check, we're re-adding the option now in case anything else may break. It doesn't seem like there's much else to check. We've opted to remove the check. Hopefully this is the last time it will need to be revisited.

[erikjohnston]

TBH I'd rather we removed it, as otherwise its going to confuse people why its there at all. If we don't remove it now, then when will we?

Worth double checking that that string doesn't turn up anywhere else in the code base too (if you haven't)

[anoadragon453]

TBH I'd rather we removed it, as otherwise its going to confuse people why its there at all. If we don't remove it now, then when will we?

True, I figured it safer if we re-added it now and then evaluated later whether it is actually safe to remove, but if this is that evaluation then we can just remove it.

Worth double checking that that string doesn't turn up anywhere else in the code base too (if you haven't)

Yeah, seems to be.

[erikjohnston]

TBH I'd rather we removed it, as otherwise its going to confuse people why its there at all. If we don't remove it now, then when will we?

True, I figured it safer if we re-added it now and then evaluated later whether it is actually safe to remove, but if this is that evaluation then we can just remove it.

Fair, it's just that I don't think we'll have any more info than we do now 🙂