This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
clean up device key/cross-signature handling. #8206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
changed the title
richvdh
force-pushed
the
rav/cleanup_get_devices/work
branch
3 times, most recently
from
db71bb0
to
bf852b7
Compare
We have three things which all call `_get_e2e_device_keys_and_signatures_txn` with their own `runInteraction`. Factor out the common code.
richvdh
force-pushed
the
rav/cleanup_get_devices/work
branch
from
bf852b7
to
4acae62
Compare
richvdh
force-pushed
the
rav/cleanup_get_devices/work
branch
from
4acae62
to
cc05c5a
Compare
I think this is simpler (and moves stuff out of the db threads)
All the callers want this info in the same place, so let's reduce the duplication by doing it here.
richvdh
force-pushed
the
rav/cleanup_get_devices/work
branch
from
cc05c5a
to
69e655f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's my intention to break this into smaller PRs, but I'm opening this one to stop me forgetting about it.
Currently it's based on #8204 and #8205.