This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
WIP: Send ephemeral events to appservices #8366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
added
the
X-Awaiting-Changes
|
@Half-Shot Can this be closed now that a bunch of this was moved into a separate PR? Or are you planning to rebase it with the remaining bits? |
|
Yeah, I'll likely do this PR again based upon latest so this can be closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2954
This is a super WIP change to get synapse to send events to appservices, using the un-specced
/_matrix/app/unstable/uk.half-shot.appservice/ephemeralendpoint (implementing this comment https://github.com/matrix-org/matrix-doc/pull/2409/files#r491375414).Currently this sends typing, read receipts, and presence to appservices. Device messages may take another path, as they aren't typical EDUs and need to be retried, whereas these events are expected to be dropped if they don't reach the appservice.
There are some inefficiencies in this code that I'm less pleased with, like determining which appservices should see presence has some bad worst case performance.