Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Refactor email summary generation. #9260

Merged
merged 7 commits into from
Feb 1, 2021
Merged

Refactor email summary generation. #9260

merged 7 commits into from
Feb 1, 2021

Commits on Jan 28, 2021

  1. Split the summary method into two. 

    This reduces indentation.
    @clokep
    clokep committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    67a6915 View commit details
    Browse the repository at this point in the history

  2. Add a missing type hint.

    @clokep
    clokep committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    0b51f65 View commit details
    Browse the repository at this point in the history

  3. Share code between the single and multi-room cases. 

    This changes the behavior of the summary returned to be based on
the number of senders, instead of based on the number of rooms.
    @clokep
    clokep committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    6f33c1e View commit details
    Browse the repository at this point in the history

  4. Add an additional test.

    @clokep
    clokep committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    b88da2a View commit details
    Browse the repository at this point in the history

  5. Do not else-return.

    @clokep
    clokep committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    3c69dc5 View commit details
    Browse the repository at this point in the history

  6. Newsfragment

    @clokep
    clokep committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    d7ed3f6 View commit details
    Browse the repository at this point in the history

  7. Typo fix.

    @clokep
    clokep committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    1a7198f View commit details
    Browse the repository at this point in the history