Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix version for bugbear #9734

Merged
merged 2 commits into from
Apr 2, 2021
Merged

Fix version for bugbear #9734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70d7704
fix version for bugbear
ShadowJonathan Apr 2, 2021
5b37431
news
ShadowJonathan Apr 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/9734.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Pin flake8-bugbear's version.
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def exec_file(path_segments):
"isort==5.7.0",
"black==20.8b1",
"flake8-comprehensions",
"flake8-bugbear",
"flake8-bugbear==21.3.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@callahad @ShadowJonathan: it's a shame that no attention was given to the comment above:

We pin black so that our tests don't start failing on new releases.

This implies that we pin flake8-bugbear for some other reason?

Copy link
Contributor Author

@ShadowJonathan ShadowJonathan Apr 6, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does that comment come from?

This implies that we pin flake8-bugbear for some other reason?

No, we don't pin bugbear for any other reason.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

four lines above. Please remember to check the context around code you are changing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, i didn't see that, i was mainly focused on just pinning bugbear, should an addition to the comment be made?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it'd be nice. It may not be worth it. I'm mostly just asking that both you and @callahad remember to look for context around stuff you are changing/reviewing.

"flake8",
]

Expand Down