Add timeout for resolve_service #9776
Conversation
| try: | ||
| answers, _, _ = await make_deferred_yieldable( | ||
| self._dns_client.lookupService(service_name) | ||
| self._dns_client.lookupService(service_name, timeout=(1, 3, 11, 35)) |
There was a problem hiding this comment.
1 + 3 + 11 + 35 = 50
By the way, i saw somewhere another federation-esc timeout of 30 seconds, shouldn't this timeout sum become 25 seconds? Or is 50 seconds acceptable?
There was a problem hiding this comment.
so what's going on here? we're trying to change the timeout so that it's less than the total federation request timeout, so that we get a useful error message?
if so, it would be useful to say that in a comment.
(looks like the defaults are (1, 3, 11, 45). could you include that in the comment too)
| else: | ||
| raise e | ||
| except defer.TimeoutError as e: | ||
| raise defer.TimeoutError( |
There was a problem hiding this comment.
I'm not sure if this exception should raise "all the way" here via this, but at least it has different wording.
|
also: CI is failing. |
erikjohnston
added
the
X-Awaiting-Changes
|
closing this as it seems to be on hold for now. We can reopen if you want to pick it up again. |
3 participants
Fixes #9774
Adds a stricter timeout to
resolve_servicethat returns in 50s (smaller than the previous 60s, and the overarching 60s of timeout a federation transaction has)Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>