Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old leaves are present in gapped incremental syncs is flakey #1037

Closed
richvdh opened this issue Apr 23, 2021 · 7 comments · Fixed by #1146
Closed

Old leaves are present in gapped incremental syncs is flakey #1037

richvdh opened this issue Apr 23, 2021 · 7 comments · Fixed by #1146
Assignees
@richvdh
Labels
Z-Flaky Tests which seem to fail at random

Comments

@richvdh
Copy link
Member

richvdh commented Apr 23, 2021

see https://buildkite.com/matrix-dot-org/synapse/builds/16951#d131cd2c-199d-4e48-9709-452e63fea61e
@callahad callahad added the Z-Flaky Tests which seem to fail at random label May 14, 2021
@clokep
Copy link
Member

clokep commented Aug 4, 2021

And https://github.com/matrix-org/synapse/pull/10532/checks?check_run_id=3242345419

@richvdh
Copy link
Member Author

richvdh commented Aug 9, 2021

And https://github.com/matrix-org/synapse/pull/10520/checks?check_run_id=3236703266

@richvdh richvdh mentioned this issue Aug 9, 2021
Merged
@richvdh
Copy link
Member Author

richvdh commented Aug 23, 2021 •
edited
Loading

and https://github.com/matrix-org/synapse/pull/10192/checks?check_run_id=3402293123

@clokep
Copy link
Member

clokep commented Aug 25, 2021

And https://github.com/matrix-org/synapse/runs/3414626122

@clokep
Copy link
Member

clokep commented Sep 1, 2021

And https://github.com/matrix-org/synapse/runs/3475978691

@richvdh
Copy link
Member Author

richvdh commented Sep 9, 2021

And https://github.com/matrix-org/synapse/pull/10784/checks?check_run_id=3547200645

@richvdh
Copy link
Member Author

richvdh commented Sep 22, 2021

and https://github.com/matrix-org/synapse/pull/10879/checks?check_run_id=3674044100

@richvdh richvdh self-assigned this Sep 22, 2021
richvdh added a commit that referenced this issue Sep 22, 2021
@richvdh
Deflake Old leaves are present in gapped incremental syncs
3f7c164 
Hopefully, deflake this, by making sure that all of Bob's events hit the
synchrotron before trying to sync from Alice.

Fixes #1037
richvdh added a commit that referenced this issue Sep 22, 2021
@richvdh
Deflake Old leaves are present in gapped incremental syncs
01639e2 
Hopefully, deflake this, by making sure that all of Bob's events hit the
synchrotron before trying to sync from Alice.

Fixes #1037
richvdh added a commit that referenced this issue Sep 22, 2021
@richvdh
Deflake Old leaves are present in gapped incremental syncs
a7261b8 
Hopefully, deflake this, by making sure that all of Bob's events hit the
synchrotron before trying to sync from Alice.

Fixes #1037
@richvdh richvdh mentioned this issue Sep 22, 2021
Merged
richvdh added a commit that referenced this issue Sep 22, 2021
@richvdh
Deflake and clean up lazy-loading tests (#1146)
f8ef7a2 
* Deflake `Old leaves are present in gapped incremental syncs`

Hopefully, deflake this, by making sure that all of Bob's events hit the
synchrotron before trying to sync from Alice.

Fixes #1037

* Deflake `Gapped incremental syncs include all state changes`

Give this one the same treatment.

Fixes #1043.

* Deflake `Leaves are present in non-gapped incremental syncs`

Another case of the same.

Fixes #1045

* Update `The only membership state in initial sync`...

This is non-functional, just a cleanup:

 * use `send_filler_messags_synced` instead of a loop
 * use `check_filler_event` instead of a local definition
 * fix a warning `Use of uninitialized value in numeric eq (==)`
 * use `die` instead of `croak`, given we want to log the right line number.

* Use `matrix_send_filler_messages_synced` elsewhere

... for consistency, and because it's shorter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richvdh richvdh

Labels
Z-Flaky Tests which seem to fail at random
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deflake and clean up lazy-loading tests matrix-org/sytest
3 participants
@callahad @clokep @richvdh