Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GET /rooms/:room_id/aliases lists aliases is broken #1055

Closed
richvdh opened this issue Jun 2, 2021 · 4 comments · Fixed by #1056
Closed

GET /rooms/:room_id/aliases lists aliases is broken #1055

richvdh opened this issue Jun 2, 2021 · 4 comments · Fixed by #1056
Labels
Z-Flaky Tests which seem to fail at random

Comments

@richvdh
Copy link
Member

richvdh commented Jun 2, 2021

https://buildkite.com/matrix-dot-org/synapse/builds/17676#b7558b07-4ab8-4c9d-bb13-6a93f758ba31
@richvdh
Copy link
Member Author

richvdh commented Jun 2, 2021

and https://buildkite.com/matrix-dot-org/synapse/builds/17677#9b08c41e-064c-4e8e-9580-4d7be77137ac

@richvdh richvdh added the Z-Flaky Tests which seem to fail at random label Jun 2, 2021
@richvdh
Copy link
Member Author

richvdh commented Jun 3, 2021

and https://github.com/matrix-org/synapse/pull/9224/checks?check_run_id=2736673808 and https://buildkite.com/matrix-dot-org/synapse/builds/17709#76100891-1188-41bf-a3db-cb0c4b669a08

@richvdh richvdh changed the title GET /rooms/:room_id/aliases lists aliases is flakey GET /rooms/:room_id/aliases lists aliases is broken Jun 3, 2021
@richvdh
Copy link
Member Author

richvdh commented Jun 3, 2021

given how many times that has failed in the last 24h, I assume it's something broken rather than flaky.

@richvdh richvdh mentioned this issue Jun 3, 2021
Merged
4 tasks
@richvdh
Copy link
Member Author

richvdh commented Jun 3, 2021

looks like this got broken by #1053: the problem is that the request to set the alias now goes to the master, while the query goes to the client_reader.

richvdh added a commit that referenced this issue Jun 3, 2021
@richvdh
Retry aliases query
779ffc0 
Also, switch to the stable endpoint, now that Synapse supports it.

Fixes #1055
@richvdh richvdh mentioned this issue Jun 3, 2021
Merged
richvdh added a commit that referenced this issue Jun 4, 2021
@richvdh
Retry aliases query (#1056)
4c80d2c 
Also, switch to the stable endpoint, now that Synapse supports it.

Fixes #1055
This was referenced Oct 17, 2022
Closed
Open
@matrixbot matrixbot mentioned this issue Dec 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Z-Flaky Tests which seem to fail at random
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Retry aliases query matrix-org/sytest
1 participant
@richvdh