-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a consistent public baseurl. #1011
Conversation
The failing logs in this case seems to have an additional:
But not sure why that's happening from this change. |
This was because |
lib/SyTest/Homeserver/Synapse.pm
Outdated
@@ -172,7 +172,7 @@ sub start | |||
my $config_path = $self->{paths}{config} = $self->write_yaml_file( "config.yaml" => { | |||
server_name => $self->server_name, | |||
log_config => $log_config_file, | |||
public_baseurl => "http://${bind_host}:$unsecure_port", | |||
public_baseurl => "https://${bind_host}:$secure_port", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do wonder if this has to take into account the $WANT_TLS
option somewhere? 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it work with --no-tls
still with this? Can we use the unsecure port if its enabled or does that break stuff?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL that was a flag. 😄 It did break with that, I pushed a commit fixing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me too! I was like "WTF is WANT_TLS??"
d0c7e1b
to
f2b6569
Compare
Looks like this PR broke Sytest for Dendrite:
Apparently it wasn’t highlighted in the checks here because the Dendrite pipelines are soft-failed — we may want to do something about that too. |
Oh, sorry about that! I saw all green ✅ and assumed it was OK. 😢 I agree that we should update the pipelines to make Dendrite pass. |
I'm really not thrilled about this change: it's very confusing, and lacks documentation.
Adding required methods to a base class without checking the implementations of that class is pretty poor form too. Finally, @neilalexander: the commit comment on eed37c2 is confusing: it looks like it was part of this PR, whereas it wasn't. Please don't commit anything direct to develop that isn't completely trivial, and please don't add PR numbers to the subject unless it's actually part of the PR in question. I think I'm going to have a go at cleaning up public_baseurl. |
#1014 sets out to improve this. |
This sets
public_baseurl
in the Synapse config to match what is provided viaServerInfo
.Note that the
cas_config.service_url
was deprecated in matrix-org/synapse#9199 so we don't need to provide it anymore.Hopefully will fix the build issues in matrix-org/synapse#9313.