-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test that moving presence off master works #1025
Conversation
lib/SyTest/Homeserver/Synapse.pm
Outdated
|
||
writer => main::alloc_port( "writer[$idx]" ), | ||
writer_metrics => main::alloc_port( "writer[$idx].metrics" ), | ||
writer_manhole => main::alloc_port( "writer[$idx].manhole" ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't think of a better name than "writer"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly unimaginative, but simply stream_writer
? Or non_events_stream_writer
? I don't think just seeing "writer" in the logs would tell me much.
or write-o-tron 6000
?
Oh I've messed this up by the looks of it. |
(that should fix it) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good in it's current state, though I left some suggestions for small improvements.
lib/SyTest/Homeserver/Synapse.pm
Outdated
|
||
writer => main::alloc_port( "writer[$idx]" ), | ||
writer_metrics => main::alloc_port( "writer[$idx].metrics" ), | ||
writer_manhole => main::alloc_port( "writer[$idx].manhole" ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly unimaginative, but simply stream_writer
? Or non_events_stream_writer
? I don't think just seeing "writer" in the logs would tell me much.
or write-o-tron 6000
?
# If presence is on a different worker it may take a while for it to | ||
# propagate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users always receive their own presence down sync:
sytest/tests/31sync/05presence.pl
Line 3 in 0d59907
test "User sees their own presence in a sync", |
In which case, it might be better to write a matrix_set_presence_status_synced
method.
...but also: meh, this works.
Tests matrix-org/synapse#9820