Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that moving presence off master works #1025

Merged
merged 6 commits into from
Apr 29, 2021
Merged

Conversation

erikjohnston
Copy link
Member


writer => main::alloc_port( "writer[$idx]" ),
writer_metrics => main::alloc_port( "writer[$idx].metrics" ),
writer_manhole => main::alloc_port( "writer[$idx].manhole" ),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't think of a better name than "writer"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly unimaginative, but simply stream_writer? Or non_events_stream_writer? I don't think just seeing "writer" in the logs would tell me much.
or write-o-tron 6000?

@erikjohnston erikjohnston requested a review from a team April 23, 2021 09:53
@erikjohnston
Copy link
Member Author

Oh I've messed this up by the looks of it.

@erikjohnston
Copy link
Member Author

(that should fix it)

Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good in it's current state, though I left some suggestions for small improvements.


writer => main::alloc_port( "writer[$idx]" ),
writer_metrics => main::alloc_port( "writer[$idx].metrics" ),
writer_manhole => main::alloc_port( "writer[$idx].manhole" ),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly unimaginative, but simply stream_writer? Or non_events_stream_writer? I don't think just seeing "writer" in the logs would tell me much.
or write-o-tron 6000?

Comment on lines +80 to +81
# If presence is on a different worker it may take a while for it to
# propagate.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users always receive their own presence down sync:

test "User sees their own presence in a sync",

In which case, it might be better to write a matrix_set_presence_status_synced method.

...but also: meh, this works.

@erikjohnston erikjohnston merged commit af623da into develop Apr 29, 2021
@erikjohnston erikjohnston deleted the erikj/move_presence branch April 29, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants