Goodbye, synapse's scripts directory #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMRobertson
changed the title
|
Are any of these scripts even used in sytest or was it just for consistency? |
I suspect just for consistency. But let's see how the sytest jobs on matrix-org/synapse#12118 fair. |
clokep
approved these changes
Mar 1, 2022
|
Many thanks Patrick! |
They passed. I'm confident that we don't use the scripts in sytest anywhere and a quick grep shows no evidence to the contrary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In matrix-org/synapse#12118 I am moving scripts into synapse to make CI config neater and tidier. Update Sytest's glue scripts to no longer require the scripts directory to be present.