Disable version control tagging for dendrite build #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change disables tagging the dendrite binary with version control information. This allows running sytest with docker on dendrite source code that was mounted from a git worktree directory.
Motivation:
If running go install/build inside of a git repository, go relies on it being a fully functioning repository in order to tag the binary with relevant build information. If that git repository is not fully functioning then go install/build will fail.
When mounting a git worktree into a docker container the git repository is broken unless you have also mounted the entire filesystem path up to that point. This is due to git worktrees not supporting relative paths.
To prevent from having to either manipulate default git worktree setups or adding further complexity to the dendrite mounting procedure, it is simplest to disable the version control tagging in the go install command.