Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "bug" & "fixed" parameters, and reimplement functionality with a blacklist #638

Merged
merged 2 commits into from
Jul 4, 2019

Conversation

anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented Jul 3, 2019

Sytest has a feature that allows you to mark a test as expected fail, along with a bug ID with the reasoning for it. This is nice, but really only works in the context of a single homeserver, where tests were being disabled for everyone because something didn't work in Synapse.

Since homeserver-specific test white/blacklist was added, we can recreate the functionality of the bug parameter using a blacklist instead.

This PR pairs with matrix-org/synapse#5611

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

run-tests.pl Show resolved Hide resolved
@anoadragon453 anoadragon453 changed the title Remove bug, fixed parameters, and reimplement functionality with a blacklist Remove "bug" & "fixed" parameters, and reimplement functionality with a blacklist Jul 4, 2019
@anoadragon453 anoadragon453 merged commit dbe85e3 into develop Jul 4, 2019
@anoadragon453 anoadragon453 deleted the anoa/remove_bug_param branch July 4, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants