Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flakiness due to create_room_synced #702

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Commits on Sep 11, 2019

  1. Fix flakiness due to create_room_synced

    When we create a room, it's possible for a subsequent /sync to receive subset of
    the intial events in that room. This was making some tests [1] flaky when
    running in worker mode.
    
    AFAICT there's nothing in the spec which forbids this behaviour. By way of a
    workaround, we send a test message in the new room and wait for it to turn up
    over /sync.
    
    However, a corollary is that we can't rely on the /sync to contain all the
    events in the room. Solution to that is to sync again in tests that actually
    care about the sync body.
    
    [1]: notably 'A message sent after an initial sync appears in the timeline of
    an incremental sync.'
    richvdh committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    82b7120 View commit details
    Browse the repository at this point in the history