Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests where the session is abused for interactive auth. #830

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

clokep
Copy link
Member

@clokep clokep commented Mar 11, 2020

This attempts to make some (currently failing) test cases where the session is abused to change the item being acted upon between initiating ui-auth and completing it.
matrix-org/synapse#7068

@clokep
Copy link
Member Author

clokep commented Mar 23, 2020

This will need matrix-org/synapse#7068 merged before passing. I failed to name the branches the same. Oops!

@clokep clokep force-pushed the clokep/ui-auth-session-tests branch from 205d7b9 to 7a4929c Compare March 26, 2020 11:58
@clokep clokep marked this pull request as ready for review March 26, 2020 12:12
@clokep clokep requested a review from a team March 26, 2020 12:34
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@clokep clokep merged commit e6ca894 into develop Mar 30, 2020
@clokep clokep deleted the clokep/ui-auth-session-tests branch March 30, 2020 11:27
anoadragon453 added a commit that referenced this pull request Apr 27, 2020
…rite_whitelist_annotation

* 'develop' of github.com:matrix-org/sytest: (42 commits)
  Fix OFFLINE support for the sytest-synapse docker image (#858)
  Add support for running worker mode against redis (#857)
  route GET account_data requests to client_reader (#855)
  Test that users receive updates for their own devices (#854)
  Add tests for SSO + user interactive authentication. (#845)
  Modify login tests to be spec compliant
  Make message history pagination test less flaky (#851)
  Small comment fixes for consistency (#808)
  Change room_fixture to run matrix_create_room_synced by default (#848)
  Update dendrite docs with new whitelist/blacklist info (#849)
  Add test for querying remote public rooms list with local server_name (#847)
  Add more logging to "Guest user can set display names" (#846)
  Add test for updating room aliases on upgraded room join (#844)
  Add tests to ensure that the operation cannot be modified during interactive auth. (#830)
  fix the CAS login test (#829)
  Update NOT_FOUND error to BAD_ALIAS error to be spec compliant. (#837)
  Missing bits
  Use r0 instead of 'unstable' for joined_members|rooms
  Add test to optionally keep other sessions when modifying a user's password. (#832)
  Remove tests that call query_auth endpoint. (#827)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants