test peeking via MSC2753 on dendrite #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ara4n
changed the title
15 tasks
clokep
reviewed
Aug 31, 2020
kegsay
reviewed
Sep 2, 2020
anoadragon453
pushed a commit
to matrix-org/synapse
that referenced
this pull request
Sep 9, 2020
Dendrite's implementing MSC2753 over at matrix-org/dendrite#1370 to prove the implementation for MSC purposes, and so sytest has sprouted tests for it over at matrix-org/sytest#944. But we don't want them to run on synapse until synapse implements it.
kegsay
reviewed
Sep 10, 2020
| @@ -16,7 +16,7 @@ | |||
| content => { | |||
| visibility => "public", | |||
| # This is just the localpart | |||
| room_alias_name => "30room-create", | |||
| room_alias_name => "30room-create-".time, | |||
There was a problem hiding this comment.
it was causing test fails when run on an existing db if that alias already existed.
kegsay
approved these changes
Sep 10, 2020
ara4n
added a commit
to matrix-org/dendrite
that referenced
this pull request
Sep 10, 2020
Initial implementation of MSC2753, as tested by matrix-org/sytest#944. Doesn't yet handle unpeeks, peeked EDUs, or history viz changing during a peek - these will follow. #1370 has full details.
clokep
pushed a commit
to matrix-org/synapse
that referenced
this pull request
Sep 17, 2020
Dendrite's implementing MSC2753 over at matrix-org/dendrite#1370 to prove the implementation for MSC purposes, and so sytest has sprouted tests for it over at matrix-org/sytest#944. But we don't want them to run on synapse until synapse implements it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.