Merge mainline release v1.24.0 into dinsic #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a python script to run multiple synapse workers we may as well do that in sytest. This just makes things easier to extend.
this seems to have looped waiting for presence to turn up ever since it was first written, but as far as I can tell, the loop has never done anything, because where we don't know presence, we always make up an "offline" status. Anyway, this seems to make it more reliable.
This test seemed to be trying to check for profile info, but actually checking for presence. This seems to go all the way back to bbad767.
A follow-up from #965, in which it turns out I didn't really know what I was doing. Anyway, I think I've *really* deflaked this one this time.
…tionship when breaking sig (otherwise the test triggers *other* problems) (#963)
make sure that we pass SIGINTs and SIGTERMs through to the perl process, so that `docker stop` and ctrl-c actually stop the test runs.
This makes SyTest test Synapse's sharded event persister set up
… not cause room join to fail" (#973) * Fix "Event with an invalid signature in the send_join response should not cause room join to fail" * Indentation, again, damnit
Seems to have broken in #972
otherwise it gets swallowed. That means we can remove the same pattern from all the other places we have it.
For the second time this week (#972 and #973), I've found myself wondering why a test was failing and discovered that it is due to it relying on new functionality in Future 0.45. I guess we may as well bump the dep as try to keep our tests backwards-compatible, particularly given the CI uses the latest version.
Signed-off-by: Till Faelligen <tfaelligen@gmail.com>
* Mark admin tests as Synapse-specific * Match just the first part of the implementation name * Let's try that again * Declare tokens * Scalar vs list etc * Invert the check * Fat-fingered * Less magic * Define implementation_name for all * whois is actually in the spec * Add commented stub, try without implementation_name in ViaHaproxy/Monolith
https://matrix.org/docs/spec/appendices#user-identifiers Signed-off-by: Bohdan Horbeshko <bodqhrohro@gmail.com>
anoadragon453
added a commit
to matrix-org/synapse-dinsic
that referenced
this pull request
Jan 4, 2021
Updating DINUM's synapse branch from v1.21.2 -> v1.24.0. Shouldn't be any deprecations or config file changes to worry about. This merge is paired with one for Sytest as well: matrix-org/sytest#999
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating DINUM's sytest branch from v1.21.2 -> v1.24.0.
This merge is paired with the equivalent Synapse PR: matrix-org/synapse-dinsic#75
Note: CI is expected to fail. Check the proper CI runs in the Synapse PR.