-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an Elliptic Curve Encryption Scheme #151
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
==========================================
+ Coverage 90.37% 90.56% +0.19%
==========================================
Files 32 34 +2
Lines 1787 1908 +121
==========================================
+ Hits 1615 1728 +113
- Misses 172 180 +8 ☔ View full report in Codecov by Sentry. |
2d270d5
to
0141214
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I'm suggesting a handful of doc improvements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for splitting up the constructors. I left a few more nits.
This commits adds a Elliptic Curve Encryption Scheme, this scheme can be used in ephemeral situations where a full 3DH-based Olm session might be overkill or too hard to set up. The canonical example where this can be used is the QR code login feature in Matrix[1]. Co-authored-by: Denis Kasak <dkasak@termina.org.uk> Co-authored-by: Hugh Nimmo-Smith <hughns@users.noreply.github.com> [1]: matrix-org/matrix-spec-proposals#4108
8a41847
to
013fe79
Compare
This commits adds a Elliptic Curve Encryption Scheme, this scheme can be used in ephemeral situations where a full 3DH-based Olm session might be overkill or too hard to set up.
The canonical example where this can be used is the QR code login feature in Matrix1.
Co-authored-by: Denis Kasak dkasak@termina.org.uk
Co-authored-by: Hugh Nimmo-Smith hughns@users.noreply.github.com
Footnotes
https://github.com/matrix-org/matrix-spec-proposals/pull/4108 ↩