Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Elliptic Curve Encryption Scheme #151

Merged
merged 2 commits into from
May 15, 2024
Merged

Add an Elliptic Curve Encryption Scheme #151

merged 2 commits into from
May 15, 2024

Conversation

poljar
Copy link
Collaborator

@poljar poljar commented May 3, 2024

This commits adds a Elliptic Curve Encryption Scheme, this scheme can be used in ephemeral situations where a full 3DH-based Olm session might be overkill or too hard to set up.

The canonical example where this can be used is the QR code login feature in Matrix1.

Co-authored-by: Denis Kasak dkasak@termina.org.uk
Co-authored-by: Hugh Nimmo-Smith hughns@users.noreply.github.com

Footnotes

  1. https://github.com/matrix-org/matrix-spec-proposals/pull/4108

@poljar poljar requested a review from dkasak as a code owner May 3, 2024 15:58
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 90.56%. Comparing base (94ffb9d) to head (013fe79).
Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
src/ecies/mod.rs 91.42% 9 Missing ⚠️
src/ecies/messages.rs 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
+ Coverage   90.37%   90.56%   +0.19%     
==========================================
  Files          32       34       +2     
  Lines        1787     1908     +121     
==========================================
+ Hits         1615     1728     +113     
- Misses        172      180       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dkasak dkasak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'm suggesting a handful of doc improvements.

src/ecies/messages.rs Outdated Show resolved Hide resolved
src/ecies/messages.rs Outdated Show resolved Hide resolved
src/ecies/messages.rs Outdated Show resolved Hide resolved
src/ecies/messages.rs Outdated Show resolved Hide resolved
src/ecies/messages.rs Outdated Show resolved Hide resolved
src/ecies/mod.rs Outdated Show resolved Hide resolved
src/ecies/mod.rs Outdated Show resolved Hide resolved
src/ecies/mod.rs Outdated Show resolved Hide resolved
src/ecies/mod.rs Outdated Show resolved Hide resolved
src/ecies/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@dkasak dkasak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting up the constructors. I left a few more nits.

src/ecies/mod.rs Outdated Show resolved Hide resolved
src/ecies/mod.rs Outdated Show resolved Hide resolved
src/ecies/mod.rs Outdated Show resolved Hide resolved
src/ecies/mod.rs Outdated Show resolved Hide resolved
src/ecies/mod.rs Outdated Show resolved Hide resolved
poljar and others added 2 commits May 15, 2024 13:24
This commits adds a Elliptic Curve Encryption Scheme, this scheme can be
used in ephemeral situations where a full 3DH-based Olm session might be
overkill or too hard to set up.

The canonical example where this can be used is the QR code login
feature in Matrix[1].

Co-authored-by: Denis Kasak <dkasak@termina.org.uk>
Co-authored-by: Hugh Nimmo-Smith <hughns@users.noreply.github.com>

[1]: matrix-org/matrix-spec-proposals#4108
@poljar poljar merged commit 826d0aa into main May 15, 2024
33 checks passed
@poljar poljar deleted the poljar/qr-login-pr branch May 15, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants