Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm labels #98

Merged
merged 7 commits into from
Aug 27, 2024
Merged

rm labels #98

merged 7 commits into from
Aug 27, 2024

Conversation

Rosyrain
Copy link
Contributor

@Rosyrain Rosyrain commented Aug 20, 2024 •
edited
Loading

When an assignee event occurs, the needs-triage label will be removed if the assigned is not matrix-meow.

@Rosyrain
Copy link
Contributor Author

Rosyrain commented Aug 20, 2024 •
edited
Loading

测试action：https://github.com/Rosyrain/github_action_test/actions/runs/10469590614/job/28992959697
使用到的issue：https://github.com/Rosyrain/github_action_test/issues/50
测试结果：
image

guguducken
guguducken requested changes Aug 20, 2024
View reviewed changes
.github/workflows/robot.yaml Outdated Show resolved Hide resolved
.github/workflows/robot.yaml Outdated Show resolved Hide resolved
.github/workflows/robot.yaml Outdated Show resolved Hide resolved
actions/rm-labels/main.go Outdated Show resolved Hide resolved
actions/rm-labels/pkg/http/http.go Outdated Show resolved Hide resolved
guguducken
guguducken requested changes Aug 20, 2024
View reviewed changes
.github/workflows/robot.yaml Outdated Show resolved Hide resolved
@Rosyrain
Copy link
Contributor Author

Rosyrain commented Aug 21, 2024 •
edited
Loading

新测试action：https://github.com/Rosyrain/github_action_test/actions/runs/10482790577/job/29034514244
测试issue: https://github.com/Rosyrain/github_action_test/issues/53
存在问题：当要删除的标签不存在时，状态码返回404，我会抛出一个err进行panic处理。这个404需要单独处理么
测试结果：
image
image

@Rosyrain
Copy link
Contributor Author

测试action：https://github.com/Rosyrain/github_action_test/actions/runs/10504980325/job/29101585163
测试issue：https://github.com/Rosyrain/github_action_test/issues/53
测试结果
image

@guguducken guguducken merged commit a973423 into matrixorigin:main Aug 27, 2024
1 check passed
@Rosyrain Rosyrain deleted the rm-labels branch August 27, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guguducken guguducken guguducken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rosyrain @guguducken