Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tech Request]: Many issues with transaction workspace #14552

Closed
2 tasks done
fengttt opened this issue Feb 5, 2024 · 4 comments
Closed
2 tasks done

[Tech Request]: Many issues with transaction workspace #14552

fengttt opened this issue Feb 5, 2024 · 4 comments
Assignees
@aressu1985
Labels
kind/tech-request New feature or request resolved/v1.1.2 severity/s0 Extreme impact: Cause the application to break down and seriously affect the use
Milestone
1.2.0

Comments

@fengttt
Copy link
Contributor

fengttt commented Feb 5, 2024

Is there an existing issue for the same tech request?

  • I have checked the existing issues.

Does this tech request not affect user experience?

  • This tech request doesn't affect user experience.

What would you like to be added ?

workspace write offset management need some major rethinking.

1. Correctness.  Who can call this, and when, etc.   The API is essentially broken because this concept should NOT be exposed in the first place.
2. Performance.  There are MANY places that we are looping workspace writes.  Essentially this is an O(N^2) for multi statement transactions.  While we have not see this show up in profiling, it maybe a problem.

Why is this needed ?

No response

Additional information

No response
@fengttt fengttt added the kind/tech-request New feature or request label Feb 5, 2024
@fengttt fengttt added this to the 1.2.0 milestone Feb 5, 2024
@fengttt fengttt added the severity/s0 Extreme impact: Cause the application to break down and seriously affect the use label Feb 5, 2024
@fengttt fengttt mentioned this issue Feb 5, 2024
Closed
7 tasks
@fengttt fengttt mentioned this issue Feb 19, 2024
Closed
7 tasks
@nnsgmsone
Copy link
Contributor

no process

@nnsgmsone nnsgmsone mentioned this issue Feb 26, 2024
Merged
5 tasks
@nnsgmsone
Copy link
Contributor

nnsgmsone commented Feb 29, 2024 •
edited
Loading

等待merge

@nnsgmsone
Copy link
Contributor

fixed

@nnsgmsone nnsgmsone assigned aressu1985 and unassigned nnsgmsone Mar 4, 2024
@triump2020 triump2020 mentioned this issue Mar 4, 2024
Merged
6 tasks
@nnsgmsone nnsgmsone mentioned this issue Mar 7, 2024
Merged
7 tasks
@aressu1985
Copy link
Contributor

fixed

@triump2020 triump2020 mentioned this issue Mar 25, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aressu1985 aressu1985

Labels
kind/tech-request New feature or request resolved/v1.1.2 severity/s0 Extreme impact: Cause the application to break down and seriously affect the use
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
4 participants
@fengttt @nnsgmsone @aressu1985 @sukki37