Remove writeoffset in txn table. #14553
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengttt
requested review from
nnsgmsone,
XuPeng-SH,
triump2020 and
zhangxu19830126
as code owners
fengttt
force-pushed
the
fengttt-mo-14552
branch
from
6560222
to
30a05c0
Compare
fengttt
force-pushed
the
fengttt-mo-14552
branch
from
0cbe40b
to
1ad766e
Compare
Split getTableWrites to two functions. One can see its own writes, one cannot. Ranges should not see its own writes, but Rows(), which return affected rows should. This cannot be right.
fengttt
force-pushed
the
fengttt-mo-14552
branch
from
1ad766e
to
fa3b64d
Compare
matrix-meow
added
size/S
fengttt
force-pushed
the
fengttt-mo-14552
branch
2 times, most recently
from
4439796
to
10ac705
Compare
fengttt
force-pushed
the
fengttt-mo-14552
branch
from
10ac705
to
cf14db4
Compare
lots can go wrong. mo_account wont be created.
fengttt
force-pushed
the
fengttt-mo-14552
branch
from
cf14db4
to
fffc4be
Compare
nnsgmsone
reviewed
Feb 26, 2024
| @@ -729,12 +721,13 @@ func (tbl *txnTable) rangesOnePart( | |||
| }, uncommittedObjects...) | |||
| } | |||
|
|
|||
| for _, entry := range tbl.writes { | |||
| // XXX By all means this should by calling ForEachTableWritesStable. | |||
| tbl.db.txn.ForEachTableWritesIncludingSelf(tbl.db.databaseId, tbl.tableId, func(entry *Entry) { | |||
There was a problem hiding this comment.
That's not how it should be handled here. For the current SQL you just need to see the operation of the previous SQL. This operation may cause this SQL to see its own writes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #14552
What this PR does / why we need it:
unnecessary caching of write offset is the root of all evils.