-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cluster table support alter #11484
Cluster table support alter #11484
Conversation
@qingxinhome Thanks for your contributions! Review of Pull Request #11437: Cluster table support alter Summary: Review:
Suggestion: Add a comment explaining the purpose of the logger and how it will be used.
Suggestion: Add a comment explaining the purpose of the logger and how it will be used.
Suggestion: Improve the error messages to provide more context about the specific error that occurred.
Suggestion: Revert the removal of the check for cluster tables and add a comment explaining why cluster tables cannot be altered. Optimization:
Suggestion: Add tests to ensure the changes work as expected and do not introduce any regressions. Overall, this pull request makes some appropriate changes to add support for altering cluster tables. However, there are some areas that need improvement, such as adding comments and improving error messages. Additionally, the removal of the check for cluster tables should be reverted. Adding tests would also help ensure the changes work as expected. |
…rixone into ClusterTableSupportAlter
Approved by: @daviszhen, @heni02, @nnsgmsone, @reusee, @badboynt1, @aunjgr
Approved by: @daviszhen, @heni02, @nnsgmsone, @reusee, @badboynt1, @aunjgr
Approved by: @daviszhen, @heni02, @nnsgmsone, @reusee, @badboynt1, @aunjgr
Approved by: @daviszhen, @heni02, @nnsgmsone, @reusee, @badboynt1, @aunjgr
Approved by: @daviszhen, @heni02, @nnsgmsone, @reusee, @badboynt1, @aunjgr
Approved by: @daviszhen, @heni02, @nnsgmsone, @reusee, @badboynt1, @aunjgr
What type of PR is this?
Which issue(s) this PR fixes:
issue #11437
What this PR does / why we need it: