Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Subtask]: optimize shuffle strategy #11841

Merged
merged 10 commits into from
Sep 20, 2023
Merged

Conversation

badboynt1
Copy link
Contributor

@badboynt1 badboynt1 commented Sep 20, 2023

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #11828

What this PR does / why we need it:

if shuffle join go hybrid shuffle, shuffle group can not reuse this shuffle. may cause error.
fix this problem

@matrix-meow matrix-meow added the size/XS Denotes a PR that changes [1, 9] lines label Sep 20, 2023
@matrix-meow matrix-meow added size/S Denotes a PR that changes [10,99] lines and removed size/XS Denotes a PR that changes [1, 9] lines labels Sep 20, 2023
@badboynt1 badboynt1 changed the title fix [Subtask]: optimize shuffle strategy Sep 20, 2023
@mergify mergify bot added the kind/tech-request New feature or request label Sep 20, 2023
@CLAassistant
Copy link

CLAassistant commented Sep 20, 2023

CLA assistant check
All committers have signed the CLA.

@mergify mergify bot merged commit 12d200d into matrixorigin:main Sep 20, 2023
3 checks passed
@badboynt1 badboynt1 deleted the shuffle branch September 21, 2023 01:09
sukki37 pushed a commit that referenced this pull request Sep 22, 2023
if shuffle join go hybrid shuffle, shuffle group can not reuse this shuffle. may cause error.
fix this problem

Approved by: @aunjgr
sukki37 pushed a commit that referenced this pull request Sep 23, 2023
if shuffle join go hybrid shuffle, shuffle group can not reuse this shuffle. may cause error.
fix this problem

Approved by: @aunjgr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/tech-request New feature or request size/S Denotes a PR that changes [10,99] lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants