-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Subtask]: optimize shuffle strategy #11841
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matrix-meow
added
size/S
Denotes a PR that changes [10,99] lines
and removed
size/XS
Denotes a PR that changes [1, 9] lines
labels
Sep 20, 2023
badboynt1
requested review from
nnsgmsone,
reusee and
daviszhen
as code owners
September 20, 2023 02:40
aunjgr
approved these changes
Sep 20, 2023
sukki37
pushed a commit
that referenced
this pull request
Sep 22, 2023
if shuffle join go hybrid shuffle, shuffle group can not reuse this shuffle. may cause error. fix this problem Approved by: @aunjgr
sukki37
pushed a commit
that referenced
this pull request
Sep 23, 2023
if shuffle join go hybrid shuffle, shuffle group can not reuse this shuffle. may cause error. fix this problem Approved by: @aunjgr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #11828
What this PR does / why we need it:
if shuffle join go hybrid shuffle, shuffle group can not reuse this shuffle. may cause error.
fix this problem