fix bug: when the updated data does not change, there is no need to check the constraints #12753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heck the constraints (matrixorigin#12732) fix bug: when the updated data does not change, there is no need to check the constraints you can repro like: ``` create table f1 (a int primary key); create table c1(aa int primary key, bb int, CONSTRAINT `fk_bb` FOREIGN KEY (`bb`) REFERENCES `f1`(`a`)); insert into f1 values (1); insert into c1 values (1,1); update f1 set a=a; //MO throw error. but MySQL not. this PR will fix it ``` Approved by: @heni02, @badboynt1, @aunjgr
ouyuanning
requested review from
aunjgr,
badboynt1,
aressu1985 and
heni02
as code owners
heni02
approved these changes
Nov 15, 2023
badboynt1
approved these changes
Nov 15, 2023
aunjgr
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…check the constraints (#12732)
fix bug: when the updated data does not change, there is no need to check the constraints
you can repro like:
Approved by: @heni02, @badboynt1, @aunjgr
What type of PR is this?
Which issue(s) this PR fixes:
issue #12710
What this PR does / why we need it: