[perf] improve delete from table without where & limit #13120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matrix-meow
added
size/L
noorall
requested review from
ouyuanning,
aunjgr,
badboynt1,
nnsgmsone and
m-schen
as code owners
noorall
changed the title
m-schen
approved these changes
Dec 4, 2023
nnsgmsone
suggested changes
Dec 4, 2023
badboynt1
approved these changes
Dec 4, 2023
aunjgr
approved these changes
Dec 4, 2023
matrix-meow
added
size/M
nnsgmsone
reviewed
Dec 7, 2023
ouyuanning
reviewed
Dec 7, 2023
现在的ddl不是一个算子的形式，ddl的参数直接从plan中获取，这个if else应该没办法避免 |
matrix-meow
added
size/S
nnsgmsone
approved these changes
Dec 7, 2023
ouyuanning
approved these changes
Dec 7, 2023
noorall
added a commit
to noorall/matrixone
that referenced
this pull request
Apr 8, 2024
…13120) When a table does not have a foreign key. So for delete from table, it can be optimized to truncate. Approved by: @m-schen, @nnsgmsone, @badboynt1, @aunjgr, @ouyuanning (cherry picked from commit 118e577)
7 tasks
sukki37
pushed a commit
that referenced
this pull request
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #12845
What this PR does / why we need it:
When a table does not have a foreign key. So for delete from table, it can be optimized to truncate.