Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove segdel batch and block meta without deltaloc in ckp, cherry-pick #13952 #14023

Merged
merged 3 commits into from
Jan 7, 2024

Conversation

jiangxinmeng1
Copy link
Contributor

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #13956

What this PR does / why we need it:

set DefaultGlobalVersion = 5min

@matrix-meow matrix-meow added the size/XS Denotes a PR that changes [1, 9] lines label Jan 5, 2024
@jiangxinmeng1 jiangxinmeng1 changed the title update default global version interval update default global version interval, cherry-pick #13976 Jan 5, 2024
@mergify mergify bot requested a review from sukki37 January 5, 2024 02:06
@matrix-meow
Copy link
Contributor

@jiangxinmeng1 Thanks for your contributions!

Review:

Title: update default global version interval, cherry-pick #13976

Body:

Changes:

  • In the file pkg/vm/engine/tae/options/types.go, the value of DefaultGlobalVersionInterval is changed from time.Hour to time.Minute * 5.

Feedback:

  • The title of the pull request is clear and concise, indicating the purpose of the changes.
  • The body of the pull request provides relevant information about the type of PR, the issue it fixes, and the reason for the changes.
  • The changes made in the pull request are straightforward and limited to updating the value of DefaultGlobalVersionInterval.

Suggestions:

  • The changes made in the pull request seem appropriate and do not raise any security concerns.
  • However, it would be helpful to provide more context or explanation in the body of the pull request about why the default global version interval is being updated to 5 minutes. This would help reviewers understand the rationale behind the change.
  • Additionally, it would be beneficial to include any relevant test cases or documentation updates related to this change, if applicable.

Optimization:

  • The changes made in the pull request are minimal and focused on updating a single value. Therefore, there are no specific optimization suggestions for this pull request.

@matrix-meow matrix-meow added size/M Denotes a PR that changes [100,499] lines and removed size/XS Denotes a PR that changes [1, 9] lines labels Jan 5, 2024
…gin#13952)

remove segdel batch and block meta without deltaloc in ckp

Approved by: @XuPeng-SH
@jiangxinmeng1 jiangxinmeng1 changed the title update default global version interval, cherry-pick #13976 remove segdel batch and block meta without deltaloc in ckp, cherry-pick #13952 Jan 5, 2024
@mergify mergify bot merged commit 3f7e8e2 into matrixorigin:1.1-dev Jan 7, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement size/M Denotes a PR that changes [100,499] lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants