Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync to 1.1: compatible backwards, the old storage usage reqeust method #14452

Conversation

gouhongshen
Copy link
Contributor

@gouhongshen gouhongshen commented Jan 30, 2024

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #https://github.com/matrixorigin/MO-Cloud/issues/2196

What this PR does / why we need it:

compatible backward, the old storage usage request method.

two changes in the new version:

all the RPC method codes have been changed.
unable to handle the response of the old version tn.
this fix adds a retry with the old method and handler when a not supported error occurs.

@mergify mergify bot requested a review from sukki37 January 30, 2024 10:19
@matrix-meow matrix-meow added the size/M Denotes a PR that changes [100,499] lines label Jan 30, 2024
@mergify mergify bot added the kind/bug Something isn't working label Jan 30, 2024
mergify bot pushed a commit that referenced this pull request Jan 30, 2024
compatible backward, the old storage usage request method.

two changes in the new version:
1. all the RPC method codes have been changed.
2. unable to handle the response of the old version tn.

this fix adds a retry with the old method and handler when a `not supported` error occurs.


cherry-pick to 1.1: #14452

Approved by: @qingxinhome, @XuPeng-SH
@mergify mergify bot merged commit 2a1c5ac into matrixorigin:1.1-dev Jan 30, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/M Denotes a PR that changes [100,499] lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants