Move writeoffset update from Ranges to Relation (#14434) #14545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 因为不是所有的操作都会调用ranges，所以将更新table的wirteoffset的操作从ranges改为获取table的时候更新 Approved by: @triump2020
ouyuanning
requested review from
nnsgmsone,
XuPeng-SH and
triump2020
as code owners
nnsgmsone
approved these changes
Feb 5, 2024
triump2020
approved these changes
Feb 5, 2024
sukki37
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approved by: @triump2020
What type of PR is this?
Which issue(s) this PR fixes:
issue #14282
What this PR does / why we need it: