Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug: get deleted db when autocommit=0 (#14957) #14977

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

ouyuanning
Copy link
Contributor

fix bug: get deleted db when autocommit=0
bug repro:

create database db1;
set autocommit=0;
drop database db1;
show databases;  // return db list will contains db1

Approved by: @heni02, @nnsgmsone

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #14878

What this PR does / why we need it:

cherry pick 14957 to 1.1-dev

fix bug: get deleted db when autocommit=0
bug repro:
```
create database db1;
set autocommit=0;
drop database db1;
show databases;  // return db list will contains db1
```

Approved by: @heni02, @nnsgmsone
@matrix-meow matrix-meow added the size/S Denotes a PR that changes [10,99] lines label Mar 15, 2024
@mergify mergify bot requested a review from sukki37 March 15, 2024 01:39
@mergify mergify bot added the kind/bug Something isn't working label Mar 15, 2024
@sukki37 sukki37 merged commit eece8d8 into matrixorigin:1.1-dev Mar 15, 2024
15 of 18 checks passed
@ouyuanning ouyuanning deleted the cp-14957-to-1.1 branch April 2, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/S Denotes a PR that changes [10,99] lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants