Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the estimation of tcp packet num send back to client in mo1.2 #16412

Merged
merged 7 commits into from
May 27, 2024
Merged

Optimize the estimation of tcp packet num send back to client in mo1.2 #16412

merged 7 commits into from
May 27, 2024

Conversation

xzxiong
Copy link
Contributor

@xzxiong xzxiong commented May 27, 2024 •
edited
Loading

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #https://github.com/matrixorigin/MO-Cloud/issues/2774#issuecomment-2128654059
#16385

What this PR does / why we need it:

ref: #16364
changes:

  1. count mo do logic Flush op, see CountPacket()
  2. calculate basic number of tcp packets written to client, base on the write buffer size 4096 byte.
  3. add bvt case, verify the basic result.
  4. change config observability::tcpPacket default = true

@xzxiong
bugfix: calculate tcp packet 3 part.
8ca98a9 
1. base part: flush op cnt
2. upload part: calculation = payload / 16KiB
3. response part: calculation = sendByte / 4KiB
@xzxiong
fix: return new txnOp with TxnClient.New
174855e
@xzxiong
chore: change config observability::tcpPacket default = true
8f6785c
@matrix-meow matrix-meow added the size/XXL Denotes a PR that changes 2000+ lines label May 27, 2024
@mergify mergify bot requested a review from sukki37 May 27, 2024 06:31
@mergify mergify bot added kind/bug Something isn't working kind/enhancement labels May 27, 2024
@mergify mergify bot merged commit 05e8a40 into matrixorigin:1.2-dev May 27, 2024
17 of 19 checks passed
@xzxiong xzxiong deleted the fix_tcp_pkg_12 branch May 28, 2024 02:14
@aylei aylei mentioned this pull request Jun 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heni02 heni02 heni02 approved these changes

@sukki37 sukki37 sukki37 approved these changes

@qingxinhome qingxinhome qingxinhome approved these changes

@daviszhen daviszhen daviszhen approved these changes

@aressu1985 aressu1985 Awaiting requested review from aressu1985 aressu1985 is a code owner

Assignees
No one assigned
Labels
kind/bug Something isn't working kind/enhancement size/XXL Denotes a PR that changes 2000+ lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xzxiong @daviszhen @qingxinhome @sukki37 @heni02 @matrix-meow