Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-pick] Refactor system variable lower_case_table_names #16823

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

ck89119
Copy link
Contributor

@ck89119 ck89119 commented Jun 12, 2024

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue https://github.com/matrixorigin/MO-Cloud/issues/3142 https://github.com/matrixorigin/MO-Cloud/issues/3126 https://github.com/matrixorigin/MO-Cloud/issues/3140

What this PR does / why we need it:

  • system variable lower_case_table_names only affects db name, table name and table alias now, which affect all identifiers before
  • all identifiers (except db name, table name and table alias) are case insensitive
  • show user origin input in show xxx statements (e.g. show create table, show columns ...) and other similar statements

- system variable lower_case_table_names **only** affects db name, table name and table alias now, which affect all identifiers before
- all identifiers (except db name, table name and table alias) are **case insensitive**
- show user origin input in `show xxx` statements (e.g. `show create table, show columns ...`) and other similar statements

Approved by: @aunjgr, @daviszhen, @iamlinjunhong, @heni02
@matrix-meow matrix-meow added the size/XXL Denotes a PR that changes 2000+ lines label Jun 12, 2024
@mergify mergify bot requested a review from sukki37 June 12, 2024 07:13
@mergify mergify bot added the kind/feature label Jun 12, 2024
@mergify mergify bot merged commit ed9811a into matrixorigin:1.2-dev Jun 13, 2024
16 of 18 checks passed
@ck89119 ck89119 deleted the cp/lower_table_name_1.2 branch June 13, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature size/XXL Denotes a PR that changes 2000+ lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants