Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick-for-fix-dup-and-inconsistency #16874

Conversation

triump2020
Copy link
Contributor

@triump2020 triump2020 commented Jun 13, 2024

User description

What type of PR is this?

  • API-change
  • [ x] BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #16764

What this PR does / why we need it:

  1. Fix bug

PR Type

Bug fix


Description

  • Fixed a bug in the resetSnapshot method of the txnTable by resetting the logtailUpdated flag to false.

Changes walkthrough 📝

Relevant files
Bug fix
txn_table.go
Reset `logtailUpdated` flag in `resetSnapshot` method       

pkg/vm/engine/disttae/txn_table.go

  • Added a line to reset logtailUpdated to false in the resetSnapshot
    method.
  • +1/-0     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link

    PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review [1-5]

    1

    🧪 Relevant tests

    No

    🔒 Security concerns

    No

    ⚡ Key issues to review

    None

    Copy link

    PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

    PR Code Suggestions ✨

    No code suggestions found for PR.

    @matrix-meow matrix-meow added the size/XS Denotes a PR that changes [1, 9] lines label Jun 13, 2024
    @mergify mergify bot requested a review from sukki37 June 13, 2024 09:41
    @triump2020 triump2020 force-pushed the cherry-pick-for-fix-dup-and-inconsistency branch from 6ac2dd3 to 8c53338 Compare June 13, 2024 15:49
    @mergify mergify bot merged commit c6acc33 into matrixorigin:1.2-dev Jun 14, 2024
    17 of 18 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Bug fix Review effort [1-5]: 1 size/XS Denotes a PR that changes [1, 9] lines
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants