print file name for sync error

[LeftHandCold]

User description

What type of PR is this?

• API-change
• BUG
• Improvement
• Documentation
• Feature
• Test and CI
• Code Refactoring

Which issue(s) this PR fixes:

issue #16884

What this PR does / why we need it:

print file name for sync error

---

PR Type

Enhancement

---

Description

• Enhanced the Sync method in pkg/objectio/writer.go to include the file name in the error log for better debugging.
• Improved error handling by providing more context in the log message.

---

Changes walkthrough 📝

	Relevant files
Enhancement	writer.go Add file name to error log in Sync method                                pkg/objectio/writer.go Added logging of the file name in the error log within the Sync method. Enhanced error handling to provide more context. +3/-2

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[codiumai-pr-agent-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Reviewer Guide 🔍

⏱️ Estimated effort to review [1-5]	2
🧪 Relevant tests	No
🔒 Security concerns	No
⚡ Key issues to review	None

[codiumai-pr-agent-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Code Suggestions ✨

Category	Suggestion	Score
Enhancement	Add a check to ensure the file name is not empty before logging it Consider checking if w.fileName is not empty before logging it to avoid logging an empty file name, which might be less informative. pkg/objectio/writer.go [550-552] -logutil.Error("[DoneWithErr] Write Sync error", - zap.Error(err), - zap.String("file name", w.fileName)) +if w.fileName != "" { + logutil.Error("[DoneWithErr] Write Sync error", + zap.Error(err), + zap.String("file name", w.fileName)) +} else { + logutil.Error("[DoneWithErr] Write Sync error", + zap.Error(err)) +} Apply this suggestion Suggestion importance[1-10]: 7 Why: Adding a check for an empty file name before logging enhances the informativeness of the log, which is a good improvement for debugging and logging clarity.	7
	Add context information to the error log for better debugging Add context information to the error log to provide more details about the context in which the error occurred, which can be helpful for debugging. pkg/objectio/writer.go [550-552] logutil.Error("[DoneWithErr] Write Sync error", zap.Error(err), - zap.String("file name", w.fileName)) + zap.String("file name", w.fileName), + zap.String("context", ctx.Value("contextKey").(string))) Apply this suggestion Suggestion importance[1-10]: 4 Why: Adding additional context to the error log can be helpful, but the suggestion assumes the presence of a specific context key which may not exist, potentially leading to runtime errors.	4
Possible issue	Use a mutex lock to ensure thread safety when modifying the buffer To ensure thread safety, consider using a mutex lock when setting w.buffer to nil, as multiple goroutines might access it concurrently. pkg/objectio/writer.go [549] +w.mu.Lock() +defer w.mu.Unlock() w.buffer = nil Apply this suggestion Suggestion importance[1-10]: 6 Why: Using a mutex lock could potentially prevent race conditions if w.buffer is accessed concurrently, although the suggestion assumes the existence of concurrency which isn't explicitly shown in the provided code.	6
Maintainability	Use a Reset method to clear the buffer state instead of setting it to nil Instead of setting w.buffer to nil, consider implementing a Reset method for the buffer that can be called to clear its state, which might be more explicit and maintainable. pkg/objectio/writer.go [549] -w.buffer = nil +w.buffer.Reset() Apply this suggestion Suggestion importance[1-10]: 5 Why: Implementing a Reset method could improve code maintainability by making the buffer's state management more explicit, though it's not clear if a Reset method is already implemented or feasible.	5