Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in some cases that RPC close would not be called #17054

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

m-schen
Copy link
Contributor

@m-schen m-schen commented Jun 21, 2024

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #16741

What this PR does / why we need it:

修了网络自己发生错误的情况下,不会调用rpc.close()方法的错误,这可能会导致查询结束后资源不被释放。

@matrix-meow matrix-meow added the size/XS Denotes a PR that changes [1, 9] lines label Jun 21, 2024
@mergify mergify bot requested a review from sukki37 June 21, 2024 02:29
@mergify mergify bot added the kind/bug Something isn't working label Jun 21, 2024
@mergify mergify bot merged commit b8af730 into matrixorigin:1.2-dev Jun 21, 2024
17 of 18 checks passed
@m-schen m-schen deleted the fix-111 branch June 28, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/XS Denotes a PR that changes [1, 9] lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants