Fix rightjoin.Free hung

[zengyan1]

User description

What type of PR is this?

• API-change
• BUG
• Improvement
• Documentation
• Feature
• Test and CI
• Code Refactoring

Which issue(s) this PR fixes:

issue https://github.com/matrixorigin/MO-Cloud/issues/3338

What this PR does / why we need it:

Do not read from channel in Free()

---

PR Type

Bug fix

---

Description

• Simplified the condition for sending to the channel in the Free method across multiple files.
• Removed unnecessary channel reads for merger cases to prevent hanging.

---

Changes walkthrough 📝

Relevant files

Bug fix

types.go Simplify channel handling logic in `Free` method.                pkg/sql/colexec/right/types.go Simplified the condition for sending to the channel in the Free method. Removed unnecessary channel reads for merger cases. +2/-8      types.go Simplify channel handling logic in `Free` method.                pkg/sql/colexec/rightanti/types.go Simplified the condition for sending to the channel in the Free method. Removed unnecessary channel reads for merger cases. +2/-8      types.go Simplify channel handling logic in `Free` method.                pkg/sql/colexec/rightsemi/types.go Simplified the condition for sending to the channel in the Free method. Removed unnecessary channel reads for merger cases. +2/-8

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[codiumai-pr-agent-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Reviewer Guide 🔍

⏱️ Estimated effort to review [1-5]	2
🧪 Relevant tests	No
🔒 Security concerns	No
⚡ Key issues to review	Possible Bug: The changes in the PR remove the channel read operations for merger cases and modify the condition for sending nil to the channel. Ensure that this change does not introduce any race conditions or deadlocks, particularly in scenarios where arg.NumCPU > 1 and arg.IsMerger is false. It's crucial to verify that the new logic correctly handles all edge cases without causing the system to hang or crash.

[codiumai-pr-agent-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Code Suggestions ✨

Category	Suggestion	Score
Possible issue	Close the channel after sending nil to avoid potential deadlocks To ensure that the Channel is properly closed and to avoid potential deadlocks, consider adding a close(arg.Channel) statement after sending nil to the channel. pkg/sql/colexec/right/types.go [132] arg.Channel <- nil +close(arg.Channel) Apply this suggestion Suggestion importance[1-10]: 7 Why: Closing the channel after sending nil can indeed prevent potential deadlocks and ensure proper channel lifecycle management, which is a good practice in Go.	7
Enhancement	Extract complex condition into a well-named boolean variable for readability To improve readability and maintainability, consider extracting the condition !ctr.handledLast && arg.NumCPU > 1 && !arg.IsMerger into a well-named boolean variable. pkg/sql/colexec/right/types.go [131] -if !ctr.handledLast && arg.NumCPU > 1 && !arg.IsMerger { +shouldSendNil := !ctr.handledLast && arg.NumCPU > 1 && !arg.IsMerger +if shouldSendNil { Apply this suggestion Suggestion importance[1-10]: 6 Why: Extracting the condition into a boolean variable improves code readability and maintainability, making it easier to understand the logic at a glance.	6

[zengyan1]

https://github.com/matrixorigin/mo-nightly-regression/actions/runs/9628576836
这次测试卡住的原因是在rightjoin.Free中清理channel，当触发提前结束时，若不同并发接受到不同的hashmap，则有可能hung住。
由于rightjoin.argument有reuse且channel有足够的缓冲，channel是不需要清理的，因此将这一部分删去。

在rightjoin.build()中，判断arg.Ismerger时在receivehashmap前sleep，否则在receivehashmap后sleep，
并使用 #17038 添加的bvt case，可以稳定复现。