Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead lock #17194

Merged

Conversation

triump2020
Copy link
Contributor

@triump2020 triump2020 commented Jun 27, 2024

What type of PR is this?

  • API-change
  • [x ] BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #

https://github.com/matrixorigin/MO-Cloud/issues/3538

What this PR does / why we need it:

  1. Remove the redundant requestLock to avoid dead lock, since the PR guarantees the serializability of subscribing and unsubscribing a table by state machine.

@mergify mergify bot requested a review from sukki37 June 27, 2024 09:39
@triump2020 triump2020 requested review from volgariver6 and removed request for sukki37 June 27, 2024 09:39
@mergify mergify bot requested a review from sukki37 June 27, 2024 09:39
@matrix-meow matrix-meow added the size/S Denotes a PR that changes [10,99] lines label Jun 27, 2024
@mergify mergify bot merged commit 96392e5 into matrixorigin:1.2-dev Jun 27, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes [10,99] lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants