[bug] logtail: clear the tables in global stats when logtail re-connect

[volgariver6]

User description

What type of PR is this?

• API-change
• BUG
• Improvement
• Documentation
• Feature
• Test and CI
• Code Refactoring

Which issue(s) this PR fixes:

issue https://github.com/matrixorigin/MO-Cloud/issues/4045

What this PR does / why we need it:

clear the tables in global stats when logtail re-connect.

---

PR Type

Bug fix, Tests

---

Description

• Added a clearTables method in GlobalStats to clear the tables in the map.
• Integrated the clearTables method into the engine initialization process to ensure tables are cleared in global stats when logtail reconnects.
• Added a unit test to verify the functionality of the clearTables method.

---

Changes walkthrough 📝

	Relevant files
Bug fix	db.go Clear tables in global stats during engine initialization pkg/vm/engine/disttae/db.go Added a call to clear all tables in global stats during initialization. +3/-0
Enhancement	stats.go Implement clearTables method in GlobalStats                            pkg/vm/engine/disttae/stats.go Implemented clearTables method to clear tables in the global stats map. +9/-0
Tests	stats_test.go Add test for clearTables method in GlobalStats                      pkg/vm/engine/disttae/stats_test.go Added a test for the clearTables method in GlobalStats. +13/-0

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[qodo-merge-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Key issues to review Potential Race Condition The clearTables method uses a lock, but the RemoveTid method doesn't. This could lead to a race condition if these methods are called concurrently.

[qodo-merge-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Code Suggestions ✨

Category	Suggestion	Score
Enhancement	Simplify the code by removing an unnecessary condition Consider removing the condition if len(gs.logtailUpdate.mu.updated) > 0 as it's not necessary. Assigning a new empty map is efficient regardless of the current map's size. pkg/vm/engine/disttae/stats.go [273-275] -if len(gs.logtailUpdate.mu.updated) > 0 { - gs.logtailUpdate.mu.updated = make(map[uint64]struct{}) -} +gs.logtailUpdate.mu.updated = make(map[uint64]struct{}) Apply this suggestion Suggestion importance[1-10]: 8 Why: Removing the condition if len(gs.logtailUpdate.mu.updated) > 0 simplifies the code without affecting functionality, as assigning a new empty map is efficient regardless of the current map's size.	8
Maintainability	Rename the method to better reflect its specific functionality Consider using a more descriptive name for the clearTables method, such as clearUpdatedTables or resetLogtailUpdates, to better reflect its specific functionality. pkg/vm/engine/disttae/stats.go [269-276] -// clearTables clears the tables in the map if there are any tables in it. -func (gs *GlobalStats) clearTables() { +// clearUpdatedTables clears the updated tables in the map if there are any. +func (gs *GlobalStats) clearUpdatedTables() { gs.logtailUpdate.mu.Lock() defer gs.logtailUpdate.mu.Unlock() if len(gs.logtailUpdate.mu.updated) > 0 { gs.logtailUpdate.mu.updated = make(map[uint64]struct{}) } } Apply this suggestion Suggestion importance[1-10]: 7 Why: The suggestion to rename clearTables to clearUpdatedTables or resetLogtailUpdates improves code readability and maintainability by providing a more descriptive method name that reflects its functionality.	7