fix range checkpoint

[jiangxinmeng1]

User description

What type of PR is this?

• API-change
• BUG
• Improvement
• Documentation
• Feature
• Test and CI
• Code Refactoring

Which issue(s) this PR fixes:

issue #https://github.com/matrixorigin/MO-Cloud/issues/4098

What this PR does / why we need it:

1. fix range checkpoint
2. add log

---

PR Type

Bug fix, Enhancement

---

Description

• Improved synchronization and LSN management in driverInfo by adjusting mutex usage and adding removal of log service LSN range.
• Enhanced logging and added detailed metrics for the truncation process in LogServiceDriver, including loop count and duration.
• Added logging with timing metrics for checkpoint operations in StoreImpl, improving visibility into checkpoint and truncation processes.
• Improved logging format across modified files using zap for better clarity and consistency.

---

Changes walkthrough 📝

Relevant files

Enhancement

info.go Improve synchronization and LSN management in driverInfo  pkg/vm/engine/tae/logstore/driver/logservicedriver/info.go Improved synchronization by adjusting mutex usage. Replaced GetCardinality with IsEmpty for better clarity. Added removal of log service LSN range from validLsn. +10/-9    truncate.go Enhance logging and metrics in truncation process                pkg/vm/engine/tae/logstore/driver/logservicedriver/truncate.go Added logging for truncation process with detailed metrics. Introduced loop count and duration logging for truncation. Improved logging format using zap. +23/-2    checkpoint.go Add detailed logging and metrics for checkpoint operations pkg/vm/engine/tae/logstore/store/checkpoint.go Added logging for checkpoint operations with timing metrics. Improved logging format using zap. Enhanced visibility into checkpoint and truncation processes. +21/-0

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[qodo-merge-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Potential Race Condition The driverInfo struct has multiple mutex locks, which might lead to potential deadlocks or race conditions if not used carefully. Performance Concern The doTruncate function contains a loop that might be inefficient for large datasets. Consider optimizing this loop for better performance.

[qodo-merge-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Code Suggestions ✨

Category	Suggestion	Score
Best practice	Use more specific error types for better error handling and debugging Consider using a more specific error type instead of moerr.NewInternalErrorNoCtx. This will provide better error handling and debugging capabilities. pkg/vm/engine/tae/logstore/driver/logservicedriver/info.go [30-31] -var ErrDriverLsnNotFound = moerr.NewInternalErrorNoCtx("driver info: driver lsn not found") -var ErrRetryTimeOut = moerr.NewInternalErrorNoCtx("driver info: retry time out") +var ErrDriverLsnNotFound = moerr.NewErrorCode(moerr.ErrInternal, "driver info: driver lsn not found") +var ErrRetryTimeOut = moerr.NewErrorCode(moerr.ErrInternal, "driver info: retry time out") Apply this suggestion Suggestion importance[1-10]: 7 Why: The suggestion to use more specific error types can improve error handling and debugging capabilities, which is beneficial for maintainability and clarity. However, it is not critical to the functionality of the code.	7
	Use more descriptive variable names for better code readability Consider using a more descriptive variable name instead of t0 to improve code readability. pkg/vm/engine/tae/logstore/driver/logservicedriver/truncate.go [50] -t0 := time.Now() +truncateStartTime := time.Now() Apply this suggestion Suggestion importance[1-10]: 5 Why: More descriptive variable names enhance code readability, which is a good practice, but it is a minor change that does not affect the overall functionality of the code.	5
Maintainability	Use constants for log messages to improve maintainability Consider using a constant for the log message to avoid string duplication and improve maintainability. pkg/vm/engine/tae/logstore/driver/logservicedriver/truncate.go [29] -logutil.Info("LogService Driver", zap.Uint64(" driver start truncate", lsn)) +const msgDriverStartTruncate = "LogService Driver: driver start truncate" +logutil.Info(msgDriverStartTruncate, zap.Uint64("lsn", lsn)) Apply this suggestion Suggestion importance[1-10]: 6 Why: Using constants for log messages can reduce duplication and improve maintainability, but it is a minor improvement and does not impact the core functionality of the code.	6