cherry-pick: couple of updates #19968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
处理rollback,commit,new txn,IncrStatementID,RollbackLastStatement的接口panic Approved by: @qingxinhome
复用txnop的对象。每个前台session只创建一次。 https://github.com/matrixorigin/ci-test/actions/runs/11661100275 Approved by: @qingxinhome
原因：parseStmtExecute可能返回error了。导致prepareStmt为nil. 从prepareStmt取值放到了err判断之前。 修改：从prepareStmt取值放到了err判断之后。 Approved by: @qingxinhome
1, 修改recover捕获后，err被吞了。 2, 修改lint的recover加错的白名单。 Approved by: @qingxinhome
改进 后台sql的执行。 Approved by: @qingxinhome
qingxinhome
approved these changes
Nov 12, 2024
sukki37
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue ##19589
#18601
#19764
What this PR does / why we need it:
1, 处理rollback,commit,new txn,IncrStatementID,RollbackLastStatement的接口panic
2, 复用txnop的对象。每个前台session只创建一次。
3,
原因：parseStmtExecute可能返回error了。导致prepareStmt为nil. 从prepareStmt取值放到了err判断之前。
修改：从prepareStmt取值放到了err判断之后。
4,
5, 改进 后台sql的执行。