-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/adds reset calls as optional #181
Feature/adds reset calls as optional #181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest, that the README is updated as well.
Great feedback guys I've gone ahead and made the changes requested other than the function rename as I agree with @breml |
…r/moq into feature/adds-reset-calls-as-option
I believe all changes have been satisfied, checks are passing, waiting on you @matryer |
@matryer @cbaker Some idea when this could become available, I have a case where I share the same mock over multiple subtests since the whole setup is complex and giant. The reset call could help a lot in my case, to reset the calls in each run facilitating to read each call as expected, the test expects that each run call only once the stubbed method so what I do today without this feature is checking the calls lengths minus the calls from the previous test. What is a big effort and doesn't look as an elegant solution. I would love to facilitate this change if needed. Thanks for the great work 'til now |
Co-authored-by: Suhas Karanth <sudo-suhas@users.noreply.github.com>
Co-authored-by: Lucas Bremgartner <breml@users.noreply.github.com>
Co-authored-by: Lucas Bremgartner <breml@users.noreply.github.com>
This branch cannot be rebased due to conflicts changes look good but not able to merge. Could you rebase this branch on the main branch? |
Did we race on the comment vs the merge commit or does this still need to be done because it looks good on my side? |
Was able to merge it from the mobile app 🤷🏼 |
Realease via |
Adds fundamental mocking feature (reset calls) to moq behind optional flag, as requested here.
#157