Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic TCR sets #12

Open
matsen opened this issue Oct 30, 2018 · 0 comments
Open

Dynamic TCR sets #12

matsen opened this issue Oct 30, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@matsen
Copy link
Contributor

matsen commented Oct 30, 2018

From @krdav :

I see that you maintain my "macro like" globals defining V/J genes. They have been annoying me from the beginning because I wanted it to be dynamically defined by the dataset. However, make a sufficiently small (or single subject) hold-out set and it will surely not contain all the genes of the full dataset. It also causes compatibility issues when predicting on an completely different dataset, not used for training.
That being said if/when this is moved from notebooks towards command line scripts it may be worth defining allowed V/J genes (as well as similar info like HLA type) in an input file. This could have a default in the repo to ease use.

@matsen matsen added the paper 1 Should be done for the first paper. label Feb 21, 2019
@matsen matsen added enhancement New feature or request and removed paper 1 Should be done for the first paper. labels Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant