Skip to content
This repository has been archived by the owner on Nov 30, 2020. It is now read-only.

Define ripple as a mixin, instead of a component #267

Closed
tychenjiajun opened this issue May 25, 2019 · 3 comments · Fixed by #340
Closed

Define ripple as a mixin, instead of a component #267

tychenjiajun opened this issue May 25, 2019 · 3 comments · Fixed by #340

Comments

@tychenjiajun
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When using m-ripple component to provide custom components with a ripple effect, there's an extra unnecessary div parent element for my custom components.

Describe the solution you'd like
Define ripple as a mixin. In this way, users who implement their custom components can easily mix the ripple effect into their custom components by adding the ripple mixin.

@tychenjiajun
Copy link
Contributor Author

Sorry for bothering you @matsp, do you have any idea?

@matsp
Copy link
Owner

matsp commented May 29, 2019

@tychenjiajun sorry Iam actually moving to another country and have not much time.

@matsp
Copy link
Owner

matsp commented May 29, 2019

@tychenjiajun I think I had or wanted to implement the ripple effect as a mixin but I am not sure why I give up on that. Maybe you find it out when you implement it.

tychenjiajun added a commit to tychenjiajun/material-components-vue that referenced this issue Jul 16, 2019
matsp pushed a commit that referenced this issue Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants