Skip to content
This repository has been archived by the owner on Nov 30, 2020. It is now read-only.

fix(tab-bar): add a built-in scroller if the default slot is not a scroller #313

Merged
merged 2 commits into from
Jul 1, 2019
Merged

fix(tab-bar): add a built-in scroller if the default slot is not a scroller #313

merged 2 commits into from
Jul 1, 2019

Conversation

tychenjiajun
Copy link
Contributor

fixes #312
This PR allows users to use either

<m-tab-bar>
  <m-tab-scroller>
    <m-tab>First</m-tab>
    <m-tab>Second</m-tab>
  </m-tab-scroller>
</m-tab-bar>

or

<m-tab-bar>
  <m-tab>First</m-tab>
  <m-tab>Second</m-tab>
</m-tab-bar>

The first one is more verbose but easier for user to add classes or change style to the scroller while the second one is easier to use.

@tychenjiajun tychenjiajun changed the title fix(tab-bar): dd a built-in scroller if the default slot is not a scroller fix(tab-bar): add a built-in scroller if the default slot is not a scroller Jun 29, 2019
matsp
matsp approved these changes Jun 30, 2019
View reviewed changes
Copy link
Owner

@matsp matsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tychenjiajun tychenjiajun merged commit 0650e3d into matsp:master Jul 1, 2019
@tychenjiajun tychenjiajun deleted the tab-bar branch July 1, 2019 09:51
@tychenjiajun tychenjiajun mentioned this pull request Jul 1, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matsp matsp matsp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[m-tab-bar] Errors after switching
2 participants
@tychenjiajun @matsp