Skip to content
This repository has been archived by the owner on Nov 30, 2020. It is now read-only.

feat(elevation): add custom directive v-elevation #416

Merged
merged 4 commits into from
Aug 30, 2019
Merged

feat(elevation): add custom directive v-elevation #416

merged 4 commits into from
Aug 30, 2019

Conversation

tychenjiajun
Copy link
Contributor

No description provided.

matsp
matsp approved these changes Aug 30, 2019
View reviewed changes
Copy link
Owner

@matsp matsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for the Vue ecosystem this might be okay - for the web platform itself I would prefer a web component. LGTM anyway!

@tychenjiajun tychenjiajun merged commit 60ee206 into matsp:master Aug 30, 2019
@tychenjiajun tychenjiajun deleted the elevation branch August 30, 2019 08:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matsp matsp matsp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tychenjiajun @matsp