Skip to content
This repository has been archived by the owner on Nov 30, 2020. It is now read-only.

WIP: the next version #630

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

WIP: the next version #630

wants to merge 12 commits into from

Conversation

tychenjiajun
Copy link
Contributor

No description provided.

@tychenjiajun
Copy link
Contributor Author

I have to take some notes here or I may forget.
I'm trying to remove all the MutationObserver hacks because of performance issues. But this will also bring in some limitation. In the new Icon Toggle Button. You cannot have class and/or attributes bindings on the component that depends on the v-model state. For example
<m-icon-button v-model="isOn" :title="isOn ? 'I am on' : 'I am off'"> won't work as expected.

@tychenjiajun tychenjiajun marked this pull request as draft June 11, 2020 03:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tychenjiajun