Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support - SIMD headers and code change #42

Merged
merged 12 commits into from
Sep 5, 2021

Conversation

ashleyabraham
Copy link
Contributor

Added SIMD support to Windows10 x64, MSVC /arch:AVX2, /openmp:llvm

ashleyabraham and others added 7 commits July 28, 2021 10:12
Adding support for Windows10 x64 /arch:AVX2 SIMD Intrinsic
added notes on windows
adding windows
Updating examples
@matsui528
Copy link
Owner

Hi @ashleyabraham,
Thank you for your PR! First of all, can we make sure that msvc is used in github actions instead of gcc/clang? I'm a bit confused that CC=gcc/clang is set even for windows-latest.

working on adding windows without clang
excluding clang for windows
@ashleyabraham
Copy link
Contributor Author

ashleyabraham commented Aug 10, 2021

I'll be honest, I am not sure why it worked for windows with CC=gcc/clang, github actions somehow calls C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\x86_amd64\cl.exe but it is able to compile properly. I am not familiar enough to mess with it.

updated readme
Excluding clang from windows and ubuntu, cl from ubuntu and mac, and gcc from windows
@matsui528
Copy link
Owner

Sorry for the delay in reviewing this. LGTM!

@matsui528 matsui528 merged commit 9a7de86 into matsui528:main Sep 5, 2021
matsui528 added a commit that referenced this pull request Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants