Updated build for Windows #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaced add_reconfigure with add_configure under the Util Functions
…s libomp140_x86_64.dll which is not redistributable
# Conflicts: # README.md
Updated README.md
removed Python 3.5, and added 3.9 and 3.10
changed python version from numerical to string
changed python version to '3.x'
Added support for Windows by defining ssize_t
Changing VERSION_INFO to "VERSION_INFO" because it causes compiler errors
changed 3.x to actual version numbers
removed '3.5' as it causes build actions error
changed to setup-python@v2
added windows build support for setup-python@v2
fixing build errors
adding windows only setup
Updated PyBind11 >= 2.9
# Conflicts: # .github/workflows/build.yml
matsui528
reviewed
Mar 8, 2022
|
I guess you've forgotten to push your commits? :) |
|
(misclick the close button) |
Made modifications for Windows
|
I just committed the latest |
|
did you have any chance to look at this |
|
Sorry for the long delay... I'm swamped these days and have no time for OSS activity... Will take a look hopefully this month. I am a little bit concerned about type casts like those added in the following line. These changes are small, but could affect speed and cause bugs (I have explicitly written the code not to do such casts). I would like to take a moment to read the code and think about this part. |
|
Sorry for the extremely long delay! Let me merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub actions upgraded windows-latest to windows-2022 from windows-2019, which doesn't include C++14 toolset required for Python 3.5 setup, updated the build.yml and fixed any required changes for windows-latest to build successfully