Skip to content

Commit

Permalink
RCTModalHostView (facebook#23030)
Browse files Browse the repository at this point in the history
Summary:
This PR is related to facebook#22990

Changelog:
----------
[iOS] [Changed] - move the call to requireNativeComponent from Modal.js to RCTModalHostViewNativeComponent.js
Pull Request resolved: facebook#23030

Differential Revision: D13710032

Pulled By: cpojer

fbshipit-source-id: 822284a639f38721442c67ceff98fc99495c31b9
  • Loading branch information
nissy-dev authored and facebook-github-bot committed Jan 17, 2019
1 parent 240c464 commit 2b47141
Show file tree
Hide file tree
Showing 2 changed files with 132 additions and 3 deletions.
4 changes: 1 addition & 3 deletions Libraries/Modal/Modal.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@ const PropTypes = require('prop-types');
const StyleSheet = require('StyleSheet');
const View = require('View');

const requireNativeComponent = require('requireNativeComponent');

const RCTModalHostView = requireNativeComponent('RCTModalHostView');
const RCTModalHostView = require('RCTModalHostViewNativeComponent');

const ModalEventEmitter =
Platform.OS === 'ios' && NativeModules.ModalManager
Expand Down
131 changes: 131 additions & 0 deletions Libraries/Modal/RCTModalHostViewNativeComponent.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,131 @@
/**
* Copyright (c) Facebook, Inc. and its affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @format
* @flow
*/

'use strict';

const requireNativeComponent = require('requireNativeComponent');

import type {ViewProps} from 'ViewPropTypes';
import type {SyntheticEvent} from 'CoreEventTypes';
import type {NativeComponent} from 'ReactNative';

type OrientationChangeEvent = SyntheticEvent<
$ReadOnly<{|
orientation: 'portrait' | 'landscape',
|}>,
>;

type ModalNativeProps = $ReadOnly<{|
...ViewProps,

/**
* The `animationType` prop controls how the modal animates.
*
* See https://facebook.github.io/react-native/docs/modal.html#animationtype
*/
animationType?: ?('none' | 'slide' | 'fade'),

/**
* The `presentationStyle` prop controls how the modal appears.
*
* See https://facebook.github.io/react-native/docs/modal.html#presentationstyle
*/
presentationStyle?: ?(
| 'fullScreen'
| 'pageSheet'
| 'formSheet'
| 'overFullScreen'
),

/**
* The `transparent` prop determines whether your modal will fill the
* entire view.
*
* See https://facebook.github.io/react-native/docs/modal.html#transparent
*/
transparent?: ?boolean,

/**
* The `hardwareAccelerated` prop controls whether to force hardware
* acceleration for the underlying window.
*
* See https://facebook.github.io/react-native/docs/modal.html#hardwareaccelerated
*/
hardwareAccelerated?: ?boolean,

/**
* The `visible` prop determines whether your modal is visible.
*
* See https://facebook.github.io/react-native/docs/modal.html#visible
*/
visible?: ?boolean,

/**
* The `onRequestClose` callback is called when the user taps the hardware
* back button on Android or the menu button on Apple TV.
*
* This is required on Apple TV and Android.
*
* See https://facebook.github.io/react-native/docs/modal.html#onrequestclose
*/
onRequestClose?: ?(event?: SyntheticEvent<null>) => mixed,

/**
* The `onShow` prop allows passing a function that will be called once the
* modal has been shown.
*
* See https://facebook.github.io/react-native/docs/modal.html#onshow
*/
onShow?: ?(event?: SyntheticEvent<null>) => mixed,

/**
* The `onDismiss` prop allows passing a function that will be called once
* the modal has been dismissed.
*
* See https://facebook.github.io/react-native/docs/modal.html#ondismiss
*/
onDismiss?: ?() => mixed,

/**
* Deprecated. Use the `animationType` prop instead.
*/
animated?: ?boolean,

/**
* The `supportedOrientations` prop allows the modal to be rotated to any of the specified orientations.
*
* See https://facebook.github.io/react-native/docs/modal.html#supportedorientations
*/
supportedOrientations?: ?$ReadOnlyArray<
| 'portrait'
| 'portrait-upside-down'
| 'landscape'
| 'landscape-left'
| 'landscape-right',
>,

/**
* The `onOrientationChange` callback is called when the orientation changes while the modal is being displayed.
*
* See https://facebook.github.io/react-native/docs/modal.html#onorientationchange
*/
onOrientationChange?: ?(event: OrientationChangeEvent) => mixed,

/**
* The `identifier` is the unique number for identifying Modal components.
*/
identifier?: ?number,
|}>;

type RCTModalHostViewNativeType = Class<NativeComponent<ModalNativeProps>>;

module.exports = ((requireNativeComponent(
'RCTModalHostView',
): any): RCTModalHostViewNativeType);

0 comments on commit 2b47141

Please sign in to comment.