Skip to content

Commit

Permalink
remove unused suppressions in xplat
Browse files Browse the repository at this point in the history
Summary:
Removes unused suppressions before deploying 0.91. See D13708161 for more context on why these couldn't be removed before.

I will follow up with 2 more diffs:
1. A diff that bumps the flow version in xplat and removes unused suppressions
2. A diff that adds new suppressions for 0.91

Reviewed By: samwgoldman

Differential Revision: D13720219

fbshipit-source-id: b07dd163962fed7ff27ce3e0a4a73a71c51965d9
  • Loading branch information
jbrown215 authored and facebook-github-bot committed Jan 18, 2019
1 parent 1b851f6 commit e0910ad
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 8 deletions.
1 change: 0 additions & 1 deletion Libraries/Components/DatePicker/DatePickerIOS.ios.js
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ class DatePickerIOS extends React.Component<Props> {
mode: 'datetime',
};

// $FlowFixMe How to type a native component to be able to call setNativeProps
_picker: ?React.ElementRef<typeof RCTDatePickerNativeComponent> = null;

componentDidUpdate() {
Expand Down
1 change: 0 additions & 1 deletion Libraries/Components/ScrollView/ScrollView.js
Original file line number Diff line number Diff line change
Expand Up @@ -761,7 +761,6 @@ class ScrollView extends React.Component<Props, State> {
}

_getKeyForIndex(index, childArray) {
// $FlowFixMe Invalid prop usage
const child = childArray[index];
return child && child.key;
}
Expand Down
1 change: 0 additions & 1 deletion RNTester/js/ListViewPagingExample.js
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ class Thumb extends React.Component<{}, $FlowFixMeState> {
}

class ListViewPagingExample extends React.Component<$FlowFixMeProps, *> {
// $FlowFixMe found when converting React.createClass to ES6
constructor(props) {
super(props);
const getSectionData = (dataBlob, sectionID) => {
Expand Down
5 changes: 0 additions & 5 deletions RNTester/js/RNTesterExampleList.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ const RNTesterActions = require('./RNTesterActions');
const RNTesterExampleFilter = require('./RNTesterExampleFilter');
const View = require('View');

/* $FlowFixMe(>=0.78.0 site=react_native_android_fb) This issue was found when
* making Flow check .android.js files. */
import type {RNTesterExample} from 'RNTesterTypes';
import type {ViewStyleProp} from 'StyleSheet';

Expand Down Expand Up @@ -71,9 +69,6 @@ const renderSectionHeader = ({section}) => (
class RNTesterExampleList extends React.Component<Props, $FlowFixMeState> {
render() {
const filter = ({example, filterRegex}) =>
/* $FlowFixMe(>=0.68.0 site=react_native_fb) This comment suppresses an
* error found when Flow v0.68 was deployed. To see the error delete this
* comment and run Flow. */
filterRegex.test(example.module.title) &&
(!Platform.isTV || example.supportsTVOS);

Expand Down

0 comments on commit e0910ad

Please sign in to comment.