-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong interpretation of disposalType #35
Comments
Hey @raphaelrauwolf, I think you have the clearRect params the wrong way round |
You are right, but not really the point 😋 it's not really a big issue, just wanted to let you know. |
@raphaelrauwolf I'm not involved with the project at all but your comment came at a perfect time as I was in the middle of implementing the library and I wouldn't have noticed it myself. |
I am happy to put this change (and other changes like it) in, but just want to reemphasise that this lib is for parsing/decoding gifs, not necessarily rendering them. I made the demo quickly to showcase a rendering example. Around half of the issues seem to be about rendering, so maybe there's a need for a proper rendering lib too. I'd happily point links to it if someone builds one. |
I totally understand! And the lib, the parsing and decoding is clutch! Just wanted to limit the number of devs that stumble over the same issue and make sure they don't waste their time! |
Hey @raphaelrauwolf you here :-) thanks a lot for the tip !!! was exactly running into this |
See matt-way#35: `frame.disposalType` is used incorrectly in the demo, which had me scratching my head for a while today.
In your demo https://matt-way.github.io/gifuct-js/ , GIFs don't get rendered correctly, when you try out more complex ones.
For example try out https://media0.giphy.com/media/KzW7esJ9VRB4SuEyIA/giphy.gif
Frame.disposalType addresses what happens to the frame data AFTER painting the frame.
Quote from your link
should be something like
Love the decoder though! <3
The text was updated successfully, but these errors were encountered: